Mozilla Firefox is a free and open-source browser that has revolutionized the internet by challenging Microsoft Internet Explorer’s iron grip on the web browser market. Firefox has continued to challenge the status quo by putting the privacy and security of its users first through a wide community of volunteers, coordinated by the Mozilla Corporation.
MSc Computer Science student at TU Delft, following the Software Technology track.
Matthijs de Groot
MSc Computer Science student at TU Delft. Following the Software Technology track.
Change KeyPathType to an enum class
This PR replaces an enum with an equivalent enum class, as part of an effort to modernize C++ usage in the codebase. Some reasons for why enum classes are preferable to plain enums can be found in Bjarne Stroustrup’s C++11 FAQ (https://stroustrup[DOT]com/C++11FAQ.html#enum).
Change nsDocShell's notification of keyword-search pass a string rather than an engine
For this PR a change needs to be made to the way the engine communicates the search engine’s name to the front-end. With this change the nsDocShell no longer depends on the search service and thereby creates the possibility to change the search service to not be a XPCOM service.
This PR is currently a work in progress.
Incorrect constraint validation for select element with selected disabled option
Before this PR a
<select> element was considered invalid when its selected option had the disabled status. However the intended behaviour is that if the selected option has a value the select should be valid regardless of its status. This PR fixed that, fixed a test that assumed wrong behaviour and added a test case.
Replace addTestEngines and installTestEngine in search tests with SearchTestUtils.promiseNewSearchEngine
For this PR we had to update many tests to use a newer function SearchTestUtils.promiseNewSearchEngine, that returns a different object. It required us to rewrite some assertions to work with the new return type and we had to figure out where to get an extra input parameter from.